Skip to content

fix: fix main_binary_name includes .exe regression on Windows#11011

Merged
lucasfernog merged 3 commits intodevfrom
fix/nsis-wix-main-binary-name-exe
Sep 15, 2024
Merged

fix: fix main_binary_name includes .exe regression on Windows#11011
lucasfernog merged 3 commits intodevfrom
fix/nsis-wix-main-binary-name-exe

Conversation

@amrbashir
Copy link
Member

No description provided.

@amrbashir amrbashir requested a review from a team as a code owner September 15, 2024 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2024

Package Changes Through b65e626

There are 3 changes which include tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-bundler with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.1-rc.11 2.0.1-rc.12
@tauri-apps/cli 2.0.0-rc.14 2.0.0-rc.15
tauri-cli 2.0.0-rc.13 2.0.0-rc.14

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Legend-Master
Legend-Master previously approved these changes Sep 15, 2024
Copy link
Contributor

@Legend-Master Legend-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the details, but from testing on the API example, this sure did change the MAINBINARYNAME to api instead of api.exe

@lucasfernog lucasfernog merged commit 94e9d47 into dev Sep 15, 2024
@lucasfernog lucasfernog deleted the fix/nsis-wix-main-binary-name-exe branch September 15, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants