Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix main_binary_name includes .exe regression on Windows #11011

Merged
merged 3 commits into from
Sep 15, 2024
Merged

fix: fix main_binary_name includes .exe regression on Windows #11011

merged 3 commits into from
Sep 15, 2024

Conversation

amrbashir
Copy link
Member

No description provided.

@amrbashir amrbashir requested a review from a team as a code owner September 15, 2024 15:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 15, 2024 •
edited
Loading

Package Changes Through b65e626

There are 3 changes which include tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-bundler with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.1-rc.11 2.0.1-rc.12
@tauri-apps/cli 2.0.0-rc.14 2.0.0-rc.15
tauri-cli 2.0.0-rc.13 2.0.0-rc.14

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

Legend-Master
Legend-Master previously approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@Legend-Master Legend-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the details, but from testing on the API example, this sure did change the MAINBINARYNAME to api instead of api.exe

@lucasfernog lucasfernog merged commit 94e9d47 into dev Sep 15, 2024
14 checks passed
@lucasfernog lucasfernog deleted the fix/nsis-wix-main-binary-name-exe branch September 15, 2024 19:30
@github-actions github-actions bot mentioned this pull request Sep 15, 2024
Merged
@gschier gschier mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@Legend-Master Legend-Master Legend-Master left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @lucasfernog @Legend-Master