feat: Expose ability to enable browser extensions in WebView2#11056
Merged
amrbashir merged 8 commits intotauri-apps:devfrom Sep 19, 2024
SpikeHD:feat/browser_extensions
Merged
feat: Expose ability to enable browser extensions in WebView2#11056amrbashir merged 8 commits intotauri-apps:devfrom SpikeHD:feat/browser_extensions
amrbashir merged 8 commits intotauri-apps:devfrom
SpikeHD:feat/browser_extensions
Conversation
Contributor
Package Changes Through 831da58There are 4 changes which include tauri with prerelease, tauri-runtime-wry with prerelease, tauri-runtime with prerelease, tauri-utils with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
reviewed
Sep 19, 2024
crates/tauri/src/webview/plugin.rs
Outdated
Comment on lines
+45
to
+46
| #[serde(default)] | ||
| browser_extensions_enabled: bool, |
Member
There was a problem hiding this comment.
Since JS is not a secure context, this value shouldn't be set from JS. cc @tweidinger
amrbashir
approved these changes
Sep 19, 2024
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #10909.
wryto0.44.0, which introducesbrowser_extensions_enabledfor Windows (from feat: Expose ability to enable browser extensions in WebView2 wry#1356)WebviewWindowBuilderandWindowConfigstructs to include that same configurationbrowser_extensions_enabled(bool)toWebviewWindowBuilder