feat(bundler): improve GitHub mirror URL generation with custom templates#11096
Merged
amrbashir merged 17 commits intotauri-apps:devfrom Sep 24, 2024
thep0y:dev
Merged
feat(bundler): improve GitHub mirror URL generation with custom templates#11096amrbashir merged 17 commits intotauri-apps:devfrom thep0y:dev
amrbashir merged 17 commits intotauri-apps:devfrom
thep0y:dev
Conversation
…ates - Add support for custom GitHub mirror URL templates via `TAURI_BUNDLER_TOOLS_GITHUB_MIRROR_TEMPLATE` env var - Refactor URL generation logic into separate functions for better modularity - Implement regex-based parsing of GitHub URLs to extract components - Add unit tests for new URL generation functionality - Remove direct dependency on `ureq::AgentBuilder` in favor of more flexible approach - Update `create_agent_and_url` function to use new URL generation methods
Contributor
Package Changes Through 768dce7There are 10 changes which include @tauri-apps/api with prerelease, tauri-bundler with prerelease, tauri-cli with prerelease, tauri with prerelease, tauri-runtime-wry with prerelease, tauri-runtime with prerelease, tauri-utils with prerelease, @tauri-apps/cli with prerelease, tauri-build with prerelease, tauri-codegen with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Sep 23, 2024
Co-authored-by: Amr Bashir <github@amrbashir.me>
Co-authored-by: Amr Bashir <github@amrbashir.me>
…ate tests to use named constants for URLs
amrbashir
requested changes
Sep 24, 2024
amrbashir
reviewed
Sep 24, 2024
… handling - Change `generate_mirror_url_from_base` and `generate_alternative_url` to return `Option<T>` instead of `crate::Result<Option<T>>`. - Simplify the logic in `create_agent_and_url` by removing the `crate::Result` wrapper. - Remove unnecessary `Ok` and `?` usage, streamline error handling.
Combines two similar test functions into a single parameterized test for better maintainability and easier addition of future test cases.
lucasfernog
reviewed
Sep 24, 2024
- Renamed `generate_mirror_url_from_template` to `generate_github_mirror_url_from_template` - Renamed `generate_mirror_url_from_base` to `generate_github_mirror_url_from_base` - Renamed `generate_alternative_url` to `generate_github_alternative_url`
amrbashir
reviewed
Sep 24, 2024
amrbashir
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TAURI_BUNDLER_TOOLS_GITHUB_MIRROR_TEMPLATEenv varureq::AgentBuilderin favor of more flexible approachcreate_agent_and_urlfunction to use new URL generation methodsCloses: #10497