Skip to content

fix(windows): fix command bug in update elevated task (fix #11216) #11217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

kittuov
Copy link
Contributor

@kittuov kittuov commented Oct 4, 2024

The command present in update-task.xml will fail if there are any spaces in either the project name or "username" of the target machine.

Fixed the command to properly escape such scenarios

More info about the bug is present in the issue #11216

@kittuov kittuov requested a review from a team as a code owner October 4, 2024 05:03
@kittuov kittuov changed the title fix(windows): fix command bug in update elevated task (fix #11216) fix(windows): fix command bug in update elevated task (fix #11216 ) Oct 4, 2024
@kittuov kittuov changed the title fix(windows): fix command bug in update elevated task (fix #11216 ) fix(windows): fix command bug in update elevated task (fix #11216) Oct 4, 2024
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a change file in .changes directory?

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Package Changes Through c52ed5d

There are 3 changes which include tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.1 2.0.2
@tauri-apps/cli 2.0.1 2.0.2
tauri-cli 2.0.1 2.0.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

kittuov and others added 2 commits October 4, 2024 12:19
Co-authored-by: Amr Bashir <github@amrbashir.me>
Co-authored-by: Amr Bashir <github@amrbashir.me>
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir merged commit 858b351 into tauri-apps:dev Oct 4, 2024
14 checks passed
@kittuov kittuov deleted the fix/elevated-update-task-fix branch October 4, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants