fix(bundler): wrap Exec in desktop with quotes, rename appimage main binary if has spaces
#11218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n binary if has spaces
Package Changes Through e6ac2e9There are 4 changes which include @tauri-apps/api with patch, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
lucasfernog
reviewed
Oct 5, 2024
lucasfernog
reviewed
Oct 5, 2024
| fs::copy(main_binary_path, new_path)?; | ||
|
|
||
| let main_binary = settings.main_binary_mut()?; | ||
| main_binary.set_name(main_binary_name_kebab); |
There was a problem hiding this comment.
are you sure we need this? isn't the quotes enough?
There was a problem hiding this comment.
Unfortunately not, tried a couple of ways, wrapping in quotes, single quotes, replacing whitespace with \s, none of them worked for appimage
lucasfernog
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.