Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): resolve bundle > icon glob when searching for .ico for MSI installer #11315

Merged
merged 4 commits into from
Oct 12, 2024
Merged

fix(cli): resolve bundle > icon glob when searching for .ico for MSI installer #11315

merged 4 commits into from
Oct 12, 2024

Conversation

amrbashir
Copy link
Member

closes #11220

@amrbashir amrbashir requested a review from a team as a code owner October 11, 2024 04:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Package Changes Through 9a0961f

There are 4 changes which include tauri with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-bundler with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.2 2.0.3
tauri 2.0.2 2.0.3
@tauri-apps/cli 2.0.2 2.0.3
tauri-cli 2.0.2 2.0.3

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

amrbashir and others added 3 commits October 12, 2024 03:14
@amrbashir @lucasfernog
Update crates/tauri-bundler/src/bundle/settings.rs
bd5af36 
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
@amrbashir @lucasfernog
Update crates/tauri-bundler/src/bundle/windows/msi/mod.rs
271a90a 
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
@amrbashir @lucasfernog
Update crates/tauri-bundler/src/bundle/windows/msi/mod.rs
9a0961f 
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
@lucasfernog lucasfernog merged commit 069c05e into dev Oct 12, 2024
14 checks passed
@lucasfernog lucasfernog deleted the fix/cli-bundler/ico-globs branch October 12, 2024 02:23
@github-actions github-actions bot mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] .ico generated using tauri icon is incompatible when building on Windows.
2 participants
@amrbashir @lucasfernog