feat(tauri-cli): add plugin remove command #11322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 8be2ec3There are 9 changes which include tauri-utils with minor, tauri with minor, @tauri-apps/api with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-macros with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Oct 15, 2024
crates/tauri-cli/src/remove.rs
Outdated
Comment on lines
78
to
80
| "Builder::new(|pass| todo!()).build()" | ||
| } else if plugin == "localhost" { | ||
| "Builder::new(todo!()).build()" |
There was a problem hiding this comment.
tauri add command, adds todo!() because user are requested to add code here, so this code likely changes and so our check here won't work.
amrbashir
requested changes
Oct 28, 2024
amrbashir
requested changes
Nov 7, 2024
ShaunSHamilton
force-pushed
the
feat_cli-remove
branch
from
4a972b3 to
48cf511
Compare
amrbashir
approved these changes
Nov 7, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10384
TODO: I would like help understanding the failing snapshot test. Is my change invalid? Or, does the snapshot just need to be updated?