Skip to content

feat(core): fallback to Window and AppHandle resource table on close#11398

Merged
lucasfernog merged 1 commit intodevfrom
feat/resource-close-fallback
Oct 17, 2024
Merged

feat(core): fallback to Window and AppHandle resource table on close#11398
lucasfernog merged 1 commit intodevfrom
feat/resource-close-fallback

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

this changes the resource plugin close() API to fallback to the parent window and AppHandle resource tables, letting the JS to delete global resources. The need for this was brought up on tauri-apps/plugins-workspace#1860 (comment) the store plugin stores the resources in the AppHandle, and we want the existing close() API to work on global resources otherwise every consumer needs their own resource close commands

this changes the resource plugin close() API to fallback to the parent window and AppHandle resource tables, letting the JS to delete global resources.
The need for this was brought up on tauri-apps/plugins-workspace#1860 (comment)
the store plugin stores the resources in the AppHandle, and we want the existing close() API to work on global resources otherwise every consumer needs their own resource close commands
@lucasfernog lucasfernog requested a review from a team as a code owner October 17, 2024 11:14
@github-actions
Copy link
Copy Markdown
Contributor

Package Changes Through cefbadd

There are 2 changes which include @tauri-apps/api with patch, tauri with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.2 2.0.3
tauri 2.0.4 2.0.5

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog merged commit eb61d44 into dev Oct 17, 2024
@lucasfernog lucasfernog deleted the feat/resource-close-fallback branch October 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants