Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: include the path in ACL I/O errors #11575

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

kornelski
Copy link
Contributor

Errors about files missing that don't include the file path are difficult to diagnose:

failed to read plugin permissions: failed to read file: No such file or directory (os error 2)

I've added paths to ACL's I/O errors.

@kornelski kornelski requested a review from a team as a code owner November 3, 2024 18:04
@FabianLars
Copy link
Member

Thanks! I agree that this would be a valuable change but since it's exposed here https://docs.rs/tauri-utils/latest/tauri_utils/acl/enum.Error.html it would technically be a breaking change 🤔 @amrbashir any idea how to handle this?

p.s. we also need a change file before we can merge this

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Package Changes Through 2c1d142

There are 8 changes which include tauri with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime-wry with patch, @tauri-apps/api with patch, tauri-utils with minor, tauri-runtime with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.3 2.0.4
tauri-utils 2.0.2 2.1.0
tauri-bundler 2.0.4 2.0.5
tauri-runtime 2.1.1 2.1.2
tauri-runtime-wry 2.1.2 2.1.3
tauri-codegen 2.0.2 2.0.3
tauri-macros 2.0.2 2.0.3
tauri-plugin 2.0.2 2.0.3
tauri-build 2.0.2 2.0.3
tauri 2.0.6 2.1.0
@tauri-apps/cli 2.0.4 2.0.5
tauri-cli 2.0.4 2.0.5

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir
Copy link
Member

This shouldn't be a breaking change since the acl module is marked as instable, see https://docs.rs/tauri-utils/latest/tauri_utils/acl/index.html#stability

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@FabianLars
Copy link
Member

ah didn't see that, cool

@amrbashir amrbashir changed the title Include the path in ACL I/O errors enhance: include the path in ACL I/O errors Nov 4, 2024
@amrbashir amrbashir merged commit c33bbf4 into tauri-apps:dev Nov 4, 2024
24 checks passed
@kornelski kornelski deleted the acl-err-path branch November 4, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants