-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(windows, linux): Add with_extension_path
to WebviewBuilder
#11628
Conversation
Package Changes Through 3c495edThere are 6 changes which include tauri with patch, tauri-cli with patch, tauri-runtime with patch, tauri-runtime-wry with patch, tauri-utils with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Should be fixed now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This is really useful, I'm curious though, what exactly are the compiled Is there an equivalent API to AddBrowserExtension in WebKit? Or more efficient methods of establishing content blocking/simulated extension APIs? Finally, will you be looking into supporting other platforms in any way here? |
I think this https://blogs.igalia.com/carlosgc/2013/09/10/webkit2gtk-web-process-extensions/ was the best intro to webkitgtk's extensions i found when i tried it out a few years ago for #4912 (comment) a noteworthy part of my comment there:
No, webkitgtk loads all extensions it finds in the path.
Also no. the epiphany project (browser using webkitgtk) has experimental WebExtension API support https://blog.tingping.se/2022/06/29/WebExtensions-Epiphany.html but the most important(?) api for content blocking
No. This is not up to us. |
Looks like this is where one would have to start for manually implementing adblocking https://gitlab.gnome.org/GNOME/epiphany/-/blob/main/embed/ephy-filters-manager.c?ref_type=heads And if you want full extensions:
(Extension support in epiphany is close-ish, these being the main blocking issues. If these are completed it would be possible to port the code to a native WebExtension |
Now that tauri-apps/wry#1403 has been merged, it's time to bring it to the Tauri side!
Adds a function to the
WebviewBuilder
that sets the extension path. On Windows, the directory should contain unpacked Chrome extensions. On Linux, it should contain compiled.so
extensions.