fix(tauri-cli): prevent accidental object permission rm#11985
Merged
amrbashir merged 2 commits intotauri-apps:devfrom Dec 29, 2024
Merged
fix(tauri-cli): prevent accidental object permission rm#11985amrbashir merged 2 commits intotauri-apps:devfrom
amrbashir merged 2 commits intotauri-apps:devfrom
Conversation
Contributor
Package Changes Through 5f188baThere are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test failures do not make sense to me. Looks like one of the slices just moved index.
Noticed the bug with the following
src-tauri/capabilities/default.json:Details
{ "$schema": "../gen/schemas/desktop-schema.json", "identifier": "default", "description": "Capability for the main window", "windows": [ "main" ], "permissions": [ "core:path:default", "core:event:default", "core:app:default", "core:image:default", "core:resources:default", "core:menu:default", "core:tray:default", "shell:allow-open", "dialog:default", "updater:default", "core:window:allow-destroy", { "identifier": "http:default", "allow": [ { "url": "http://localhost:*" } ] } ] }Ran
tauri remove shell, and the following diff was generated:Details
--- a/src-tauri/capabilities/default.json +++ b/src-tauri/capabilities/default.json @@ -13,23 +13,8 @@ "core:resources:default", "core:menu:default", "core:tray:default", - "shell:allow-open", "dialog:default", "updater:default", - "core:window:allow-destroy", - { - "identifier": "http:default", - "allow": [ - { - "url": "http://localhost:*" - } - ] - } + "core:window:allow-destroy" ] }I am unsure what the correct
tomlconfig may look like, but assumed inline tables were the equivalent.