fix: fix panic caused by removed_resource.is_none (fix #11955)#12000
Merged
amrbashir merged 6 commits intotauri-apps:devfrom Dec 23, 2024
Merged
fix: fix panic caused by removed_resource.is_none (fix #11955)#12000amrbashir merged 6 commits intotauri-apps:devfrom
amrbashir merged 6 commits intotauri-apps:devfrom
Conversation
stringhandler
changed the title
brianp
pushed a commit
to tari-project/universe
that referenced
this pull request
Dec 18, 2024
Tauri has a bug in it which causes it to panic. I've created a PR to fix it (tauri-apps/tauri#12000) but it might take a while for them to merge it and release a new version. In the meantime, we can switch to using our fork.
amrbashir
requested changes
Dec 18, 2024
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Thank you, could you also add a change file in .changes directory?
Contributor
Package Changes Through 562f7e6There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
Author
|
Added a file in |
amrbashir
reviewed
Dec 18, 2024
Co-authored-by: Amr Bashir <github@amrbashir.me>
…i into st-fix-resource-assert
amrbashir
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11955
Fixes a panic caused by an assert when the resource random id has been used already