Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): appimage paths and filename #1227

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The appimage bundle isn't following the naming convention $appName_$version_$arch.$format, this PR fixes it.

See tauri-apps/tauri-action#31

@lucasfernog lucasfernog requested a review from a team as a code owner February 13, 2021 15:52
@lucasfernog lucasfernog requested a review from a team February 13, 2021 15:52
Copy link
Member

@nklayman nklayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me, good work! I think we could further improve this by placing the installers in an easier-to-find dir, but that's a minor change we can make later.

@lucasfernog
Copy link
Member Author

Yeah I thought about that too @nklayman

@lucasfernog lucasfernog merged commit ae76c60 into dev Feb 13, 2021
@lucasfernog lucasfernog deleted the fix/appimage-filename branch February 13, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants