Skip to content

fix(bundler): workspace detection, closes #1007#1235

Merged
lucasfernog merged 2 commits into
devfrom
fix/bundler-workspace-detection
Feb 14, 2021
Merged

fix(bundler): workspace detection, closes #1007#1235
lucasfernog merged 2 commits into
devfrom
fix/bundler-workspace-detection

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The bundler workspace detection from the official cargo-bundle project assumes that the folder name and the project name are always the same. This is never the case for Tauri though, unless your app is named src-tauri 😂 This PR changes the algorithm to compare file paths instead of project names, which is the way Cargo workspaces work.

@lucasfernog
lucasfernog requested a review from a team as a code owner February 14, 2021 20:21
@lucasfernog
lucasfernog requested a review from a team February 14, 2021 20:21
@lucasfernog
lucasfernog merged commit e34ee4c into dev Feb 14, 2021
@lucasfernog
lucasfernog deleted the fix/bundler-workspace-detection branch February 14, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant