Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): all API are now promise based #1239

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The Tauri API is now Promise-based everywhere.

promisified was removed (use invoke exclusively now)
tauri::execute_promise helper was removed (the return value is used to resolve/reject the promise instead)
tauri::execute_promise_sync helper was removed (the command message has a mainThread: bool field that allows your command to run on the main thread instead of a green thread.

@lucasfernog lucasfernog requested a review from a team as a code owner February 16, 2021 02:41
@lucasfernog lucasfernog requested review from a team February 16, 2021 02:41
@lucasfernog lucasfernog merged commit ea73325 into dev Feb 16, 2021
@lucasfernog lucasfernog deleted the refactor/promise-by-default branch February 16, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants