fix(cli): let xcode handle building for ios build --open
#12406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a debug print statement to log the command options being used. - Cleaned up commented-out code related to CLI options and build process for clarity. - Ensured the `open_and_wait` function is called consistently after processing build options. This change improves the visibility of the build command's execution details, aiding in debugging and development.
…e and adding open option handling
Package Changes Through e06ff7bThere are 5 changes which include tauri-bundler with patch, tauri-driver with patch, @tauri-apps/cli with patch, tauri-cli with patch, tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
approved these changes
Jan 25, 2025
|
kinda weirded out by slowly becomming our macos maintainer ngl 😂 I'm not too familiar with building directly in xcode but from what i understand this is working as desired. |
|
btw, for your next contributions (if any) we'll require all commits to be signed. will make a one time exception here :) |
FabianLars
changed the title
ios build --openios build --open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change so that
ios build --opendoes not build before launching xcode.This is done because xcode will bulid the entire project and some users who are using the
ios build --openflow may be using some specific xcode setup thatcall_for_targets_with_fallbackwill fail to build. For instance, building a project with a Apple Watch Companion app will not work otherwise.Changes in
fn run_buildincrates/tauri-cli/src/mobile/ios/build.rs:options.opencase early in therun_buildfunction. This ensures that the function exits immediately ifoptions.openis true, returning thehandleobject.