fix(cli): don't force native-tls feature on desktop#12445
Conversation
Package Changes Through 94d732fThere are 4 changes which include tauri-bundler with patch, tauri-cli with patch, tauri with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
actually, since we forcefully enable rustls-tls on mobile instead of checking it first like on desktop we could just as well "hardcode" it in the reqwest dependency here, no? |
|
after a tiny bit of research it seems like native-tls on mobile is nothing but a headache and rarely works so i just so i just enabled the feature permanently which effectively doesn't even change anything except the timing of when the feature is enabled. i also have a few devs on this branch already with no issues reported so far. I'd really like to get this into the patch release i wanted to do this week tbh 😅 |
But it is still removed on Desktop, right? |
|
yes and no. It should show up in your lockfile, but not like on build time as it did before(?) but when you add tauri to cargo.toml. Is that a problem for your use case? |
|
Ahh i just noticed that i phrased my earlier comment very poorly. The native-tls flag is still completely gone, it's the rustls-tls flag that's always enabled now (but only used on mobile) |
|
The issue we have is that in order to fully support offline builds, we need to add the |
|
okay so if nothing changed from what i've heard in firezone/firezone#7799 & #12448 the last changes will still work for you without needing the native-tls flag, but it will now behave as if you had added the rustls-tls feature flag if tauri-cli's feature detection wasn't broken. Compared to no feature flag like it kinda behaved in my first commit. |
|
Okay that makes sense, thank you! We already depend on |
this caused issues 2 or 3 times on discord now and since we use reqwest only on mobile it really doesn't make sense, especially considering that the http plugin etc all set rustls as default.
i also changed the deps in tauri to declare reqwest as a mobile only dependency.
Edit: fixes #12448