refactor(cli): decouple bundler from cargo#1269
Merged
Merged
Conversation
nklayman
approved these changes
Feb 21, 2021
nklayman
left a comment
Member
There was a problem hiding this comment.
Worked great for me on linux, nice job!
Member
Author
|
Seems like my commit signing isn't working properly on my laptop, i'll fix it for next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This is a step towards the CLI being used to compile other projects (e.g. Deno in the future). The bundler doesn't do Cargo specifics anymore, and the previous functionality was moved to the core CLI, in a
rustmod containing the implementation for Rust packages. The idea is to extend that to other languages in the future.