Skip to content

refactor(cli): decouple bundler from cargo#1269

Merged
lucasfernog merged 6 commits into
devfrom
refactor/decouple-bundler
Feb 21, 2021
Merged

refactor(cli): decouple bundler from cargo#1269
lucasfernog merged 6 commits into
devfrom
refactor/decouple-bundler

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This is a step towards the CLI being used to compile other projects (e.g. Deno in the future). The bundler doesn't do Cargo specifics anymore, and the previous functionality was moved to the core CLI, in a rust mod containing the implementation for Rust packages. The idea is to extend that to other languages in the future.

@lucasfernog
lucasfernog requested a review from a team as a code owner February 21, 2021 16:52
@lucasfernog
lucasfernog requested review from a team February 21, 2021 16:52

@nklayman nklayman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great for me on linux, nice job!

@lucasfernog

Copy link
Copy Markdown
Member Author

Seems like my commit signing isn't working properly on my laptop, i'll fix it for next time.

@lucasfernog
lucasfernog merged commit b1e6b74 into dev Feb 21, 2021
@lucasfernog
lucasfernog deleted the refactor/decouple-bundler branch February 21, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants