Skip to content

feat(tauri): export struct tauri::ExitRequestApi #12701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

WSH032
Copy link
Contributor

@WSH032 WSH032 commented Feb 14, 2025

Sorry for opening this PR before creating an issue (because the changes in this PR are very small).

I encountered a similar issue to tauri-apps/plugins-workspace#2161, ExitRequestApi seems to be unintentionally sealed.

pytauri needs to wrap struct ExitRequestApi to implement pyo3 bindings. Can we get this feature into tauri v2.3?


BTW, if you don't mind, can I derive Clone for ExitRequestApi?

@WSH032 WSH032 requested a review from a team as a code owner February 14, 2025 01:24
Copy link
Contributor

Package Changes Through a4a5cda

There are 8 changes which include tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor, tauri-bundler with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.2.0 2.3.0
tauri-utils 2.1.1 2.2.0
tauri-bundler 2.2.3 2.2.4
tauri-runtime 2.3.0 2.4.0
tauri-runtime-wry 2.3.0 2.4.0
tauri-codegen 2.0.4 2.0.5
tauri-macros 2.0.4 2.0.5
tauri-plugin 2.0.4 2.0.5
tauri-build 2.0.5 2.0.6
tauri 2.2.5 2.3.0
@tauri-apps/cli 2.2.7 2.3.0
tauri-cli 2.2.7 2.3.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

BTW, if you don't mind, can I derive Clone for ExitRequestApi?

i don't think anything speaks against it but i'd prefer a seperate PR for it just in case.

@WSH032
Copy link
Contributor Author

WSH032 commented Feb 15, 2025

i don't think anything speaks against it but i'd prefer a seperate PR for it just in case.

Thanks, i will open a new one later.

@FabianLars FabianLars changed the title feat(tauri): export struct tauri::ExitRequestApi feat(tauri): export struct tauri::ExitRequestApi Feb 15, 2025
@FabianLars FabianLars merged commit 7d82526 into tauri-apps:dev Feb 15, 2025
20 checks passed
@WSH032 WSH032 deleted the feat/ExitRequestApi branch February 15, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants