Skip to content

feat(tauri): derive Clone for tauri::ExitRequestApi#12710

Merged
lucasfernog merged 1 commit intotauri-apps:devfrom
WSH032:feat/clone-ExitRequestApi
Mar 15, 2025
Merged

feat(tauri): derive Clone for tauri::ExitRequestApi#12710
lucasfernog merged 1 commit intotauri-apps:devfrom
WSH032:feat/clone-ExitRequestApi

Conversation

@WSH032
Copy link
Contributor

@WSH032 WSH032 commented Feb 15, 2025

@WSH032 WSH032 requested a review from a team as a code owner February 15, 2025 15:31
@github-actions
Copy link
Contributor

Package Changes Through 7763d79

There are 8 changes which include tauri with minor, tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor, tauri-bundler with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.2.0 2.3.0
tauri-utils 2.1.1 2.2.0
tauri-bundler 2.2.3 2.2.4
tauri-runtime 2.3.0 2.4.0
tauri-runtime-wry 2.3.0 2.4.0
tauri-codegen 2.0.4 2.0.5
tauri-macros 2.0.4 2.0.5
tauri-plugin 2.0.4 2.0.5
tauri-build 2.0.5 2.0.6
tauri 2.2.5 2.3.0
@tauri-apps/cli 2.2.7 2.3.0
tauri-cli 2.2.7 2.3.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

Context for reviewers: I asked for this to be a seperate PR because it was weird to me that CloseRequestedApi implemented Clone but ExitRequestedApi did not. Is there a reason i'm missing or was it just an oversight?

@FabianLars FabianLars added this to the 2.4 milestone Feb 26, 2025
@lucasfernog
Copy link
Member

both CloseRequestedApi and ExitRequestApi must be used immediately in the event loop runner because the decision handler checks if the action was prevented immediately - meaning you can't move it to a separate thread and prevent later.
i'm not sure why you would need to clone it, but it doesn't hurt to have it.

@lucasfernog lucasfernog merged commit c108024 into tauri-apps:dev Mar 15, 2025
20 checks passed
@WSH032 WSH032 deleted the feat/clone-ExitRequestApi branch May 7, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants