Skip to content

enhance(windows): disable our in-client resizing for undecorated window with shadows #12817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir requested a review from a team as a code owner February 26, 2025 04:00
Copy link
Contributor

github-actions bot commented Feb 26, 2025

Package Changes Through bf8902a

There are 9 changes which include tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor, tauri-bundler with patch, tauri-macos-sign with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.2.0 2.3.0
tauri-utils 2.1.1 2.2.0
tauri-macos-sign 2.0.1 2.1.0
tauri-bundler 2.2.3 2.2.4
tauri-runtime 2.3.0 2.4.0
tauri-runtime-wry 2.3.0 2.4.0
tauri-codegen 2.0.4 2.0.5
tauri-macros 2.0.4 2.0.5
tauri-plugin 2.0.4 2.0.5
tauri-build 2.0.5 2.0.6
tauri 2.2.5 2.3.0
@tauri-apps/cli 2.2.7 2.3.0
tauri-cli 2.2.7 2.3.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Legend-Master
Legend-Master previously approved these changes Feb 26, 2025
@Legend-Master
Copy link
Contributor

Note that I did find a very small issue about the resize handle direction on the top right corner, which I don't really know what is causing it, probably some went off by one or so

video.mp4

@amrbashir
Copy link
Member Author

@Legend-Master this should be fixed now, it happened because we were still doing full hit testing which meant the few pixels at top-left and top-right are considered a resize handle inside the client area.

The fix is to skip doing hit testing altogether for undecorated window with shadows and consider it as top only border, because we only care for the top resize handle in that case, and is also great for performance

@amrbashir amrbashir merged commit 385a41d into dev Feb 26, 2025
20 checks passed
@amrbashir amrbashir deleted the feat/undecorated-window-shadow-outside-resizing branch February 26, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants