fix: webview closing event error#12935
Merged
amrbashir merged 4 commits intotauri-apps:devfrom Mar 10, 2025
Merged
Conversation
amrbashir
requested changes
Mar 9, 2025
Member
amrbashir
left a comment
There was a problem hiding this comment.
Thanks, can you add a change file in .changes directory and also run pnpm build inside packages/api ?
Contributor
Package Changes Through 1dfb886There are 6 changes which include tauri with minor, @tauri-apps/api with minor, tauri-runtime-wry with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
reviewed
Mar 9, 2025
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Legend-Master
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix webview closing event error
Using the above code will cause an error:

I found that the command name is wrong.It should be
webview_close.tauri/packages/api/src/webview.ts
Line 406 in 2d029a9
I tried the following code and it works: