fix: Allow the use of target dir inside frontendDist/distDir(#13287)#13294
Merged
FabianLars merged 4 commits intotauri-apps:devfrom Apr 27, 2025
Merged
Conversation
kingsword09
force-pushed
the
fix-frontenddist-target-error
branch
from
2b850ae to
1b7d31d
Compare
Contributor
Package Changes Through 6de17f2There are 4 changes which include tauri with minor, @tauri-apps/api with minor, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
kingsword09
force-pushed
the
fix-frontenddist-target-error
branch
2 times, most recently
from
3e009ca to
2b7ef74
Compare
kingsword09
force-pushed
the
fix-frontenddist-target-error
branch
from
6a82646 to
2a18e64
Compare
Member
|
didn't mean to merge the dev branch sry🙃 |
FabianLars
requested changes
Apr 27, 2025
Member
FabianLars
left a comment
FabianLars
left a comment
There was a problem hiding this comment.
thanks for the PR, just a few relatively minor things :)
FabianLars
reviewed
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(#13287): allow the target directory to be inside frontendDir as long as it is not the Rust target directory inside frontendDir.