refactor: rework transformCallback#13325
Merged
lucasfernog merged 8 commits intotauri-apps:devfrom May 5, 2025
Merged
Conversation
Contributor
Package Changes Through e9aaa14There are 5 changes which include tauri with minor, @tauri-apps/api with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
Author
|
Should we also expose |
c666295 to
2a3e02a
Compare
lucasfernog
approved these changes
May 5, 2025
Member
lucasfernog
left a comment
There was a problem hiding this comment.
you have so many great ideas ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
transformCallbackand the functions calls to it into a few js functions, and instead of binding them onwindow, we put them insidewindow.__TAURI_INTERNALS__.callbacksinsteadAlso introduced
window.__TAURI_INTERNALS__.runCallbackto replace the oldwindow['_{cb}']which is quite hard to understand what it's doingwindow.__TAURI_INTERNALS__.unregisterCallbackto replacedelete window['_{cb}']Honestly,
window['_{cb}']is super hard to understand and we also need to useformat_callbackto send a warning message to test if the callback is still there in case of webview reloads