Skip to content

chore: feature gate html manipulation code#13410

Merged
Legend-Master merged 2 commits intotauri-apps:devfrom
Legend-Master:feature-gate-html-manipulation
May 10, 2025
Merged

chore: feature gate html manipulation code#13410
Legend-Master merged 2 commits intotauri-apps:devfrom
Legend-Master:feature-gate-html-manipulation

Conversation

@Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented May 10, 2025

Some initial effort on reducing the compile time, reference: #13382

This will be a breaking change in the tauri-utils crate, and we didn't mark this module as unstable before, so I'm not entirely sure if we can do this or should we wait for v3

@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap May 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2025

Package Changes Through 000ecb3

There are 7 changes which include tauri-bundler with patch, tauri with minor, @tauri-apps/api with minor, tauri-utils with minor, tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime-wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.5.0 2.6.0
tauri-utils 2.4.0 2.5.0
tauri-bundler 2.4.0 2.4.1
tauri-runtime 2.6.0 2.6.1
tauri-runtime-wry 2.6.0 2.6.1
tauri-codegen 2.2.0 2.2.1
tauri-macros 2.2.0 2.2.1
tauri-plugin 2.2.0 2.2.1
tauri-build 2.2.0 2.2.1
tauri 2.5.1 2.6.0
@tauri-apps/cli 2.5.0 2.5.1
tauri-cli 2.5.0 2.5.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master Legend-Master marked this pull request as ready for review May 10, 2025 13:12
@Legend-Master Legend-Master requested a review from a team as a code owner May 10, 2025 13:12
@FabianLars
Copy link
Member

we release breaking changes in tauri-utils all the time much to the dismay of users (and me cause i have to tell them to run cargo update lol) so why stop now

@Legend-Master
Copy link
Contributor Author

Feel like we probably should just mark the entire crate unstable 🙃

@FabianLars
Copy link
Member

well the problem is really how we consume it in tauri. if people update tauri they often do that in a way that doesn't update tauri-utils. We should really think about something like locking minor versions internally imho.

whether we mark it unstable or not, i don't care. most of the prior breaking changes could have been non-breaking as well if we'd change the api design a bit and/or use non_exhaustive more often.

@Legend-Master
Copy link
Contributor Author

We should really think about something like locking minor versions internally imho.

Yeah, I'm also thinking about it, this is especially problematic for the plugins, we simplifies them to just 2 while we actually use some of features that requires a higher version

whether we mark it unstable or not, i don't care. most of the prior breaking changes could have been non-breaking as well if we'd change the api design a bit and/or use non_exhaustive more often.

To be fair, this crate is mostly for sharing code between the build script and the runtime crates, and probably can't be stable anyways

@Legend-Master Legend-Master merged commit b7cdb3b into tauri-apps:dev May 10, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap May 10, 2025
@Legend-Master Legend-Master deleted the feature-gate-html-manipulation branch May 10, 2025 16:13
@FabianLars
Copy link
Member

Yeah, I'm also thinking about it, this is especially problematic for the plugins, we simplifies them to just 2 while we actually use some of features that requires a higher version

I mean, the plugins are an easy fix. We can just set the minimum tauri versions they need. i thought that's what we were doing but just didn't had a reason already x)

To be fair, this crate is mostly for sharing code between the build script and the runtime crates, and probably can't be stable anyways

Maybe we shouldn't re-export it as-is from tauri then, but that's something for the next majors to worry about 🤷

montyc1999 pushed a commit to montyc1999/tauri that referenced this pull request Jun 23, 2025
* Feature gate html manipulation code

* Change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants