refactor: put dynamic acl to a feature#13418
Merged
Legend-Master merged 10 commits intotauri-apps:devfrom May 16, 2025
Merged
Conversation
Contributor
Package Changes Through 0b5ced0There are 8 changes which include tauri-bundler with patch, tauri with minor, tauri-cli with patch, tauri-codegen with minor, tauri-utils with minor, @tauri-apps/api with minor, @tauri-apps/cli with patch, tauri-runtime-wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Member
As far as i can tell it's a rare sight |
FabianLars
reviewed
May 16, 2025
FabianLars
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put dynamic ACL into a feature
dynamic-acl, this is currently enabled by default to align with the previous behaviors, you can disable it throughdefault-features = falseto reduce the final binary size by not including the ACL referencesThis helps eliminate the need of keeping a reference of all the ACLs in the release build (this saves ~100KB without any extra plugins from testing), I have tried to just remove all the references to the
RuntimeAuthority::aclfield but that's not enough for the rust's dead code elimination to remove itNot entirely sure how often this is used, if it's not commonly used, maybe we could disable it by default in v3
Reference: #12820