Skip to content

refactor: put dynamic acl to a feature#13418

Merged
Legend-Master merged 10 commits intotauri-apps:devfrom
Legend-Master:dynamic-acl-feature
May 16, 2025
Merged

refactor: put dynamic acl to a feature#13418
Legend-Master merged 10 commits intotauri-apps:devfrom
Legend-Master:dynamic-acl-feature

Conversation

@Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented May 12, 2025

Put dynamic ACL into a feature dynamic-acl, this is currently enabled by default to align with the previous behaviors, you can disable it through default-features = false to reduce the final binary size by not including the ACL references

This helps eliminate the need of keeping a reference of all the ACLs in the release build (this saves ~100KB without any extra plugins from testing), I have tried to just remove all the references to the RuntimeAuthority::acl field but that's not enough for the rust's dead code elimination to remove it

Not entirely sure how often this is used, if it's not commonly used, maybe we could disable it by default in v3

Reference: #12820

@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap May 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

Package Changes Through 0b5ced0

There are 8 changes which include tauri-bundler with patch, tauri with minor, tauri-cli with patch, tauri-codegen with minor, tauri-utils with minor, @tauri-apps/api with minor, @tauri-apps/cli with patch, tauri-runtime-wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.5.0 2.6.0
tauri-utils 2.4.0 2.5.0
tauri-bundler 2.4.0 2.4.1
tauri-runtime 2.6.0 2.6.1
tauri-runtime-wry 2.6.0 2.6.1
tauri-codegen 2.2.0 2.3.0
tauri-macros 2.2.0 2.2.1
tauri-plugin 2.2.0 2.2.1
tauri-build 2.2.0 2.2.1
tauri 2.5.1 2.6.0
@tauri-apps/cli 2.5.0 2.5.1
tauri-cli 2.5.0 2.5.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master Legend-Master marked this pull request as ready for review May 15, 2025 15:25
@Legend-Master Legend-Master requested a review from a team as a code owner May 15, 2025 15:25
@FabianLars
Copy link
Member

Not entirely sure how often this is used, if it's not commonly used, maybe we could disable it by default in v3

As far as i can tell it's a rare sight

@Legend-Master Legend-Master merged commit 1686296 into tauri-apps:dev May 16, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap May 16, 2025
@Legend-Master Legend-Master deleted the dynamic-acl-feature branch May 16, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants