fix(nsis): per-machine installer not requesting elevation when run by non-admin users#13786
Conversation
Package Changes Through 44f10e9There are 5 changes which include @tauri-apps/cli with patch, tauri-cli with patch, @tauri-apps/api with patch, tauri-bundler with patch, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
thanks for the pr :) for the reviewers someone else(?) confirmed that this works as well: https://discord.com/channels/616186924390023171/1381811624624652331 |
Legend-Master
left a comment
There was a problem hiding this comment.
Makes sense to me, nice catch
They correspond to requireAdministrator and highestAvailable in case anyone also wants to take a look
https://learn.microsoft.com/en-us/windows/win32/sbscs/application-manifests#trustinfo
According to the NSIS docs
RequestExecutionLevel highestwill request the highest execution level available for the current user.This makes it so that, if the user launching the installer is not an Administrator, the installer will not ask to be elevated and the installation will fail when reaching a step that requires admin priviledges.
Switching to
RequestExecutionLevel adminensures the installer always asks for elevation.