feat: add WebviewBuilder::on_new_window and WebviewBuilder::on_document_title_changed#13876
Merged
lucasfernog merged 14 commits intotauri-apps:devfrom Aug 16, 2025
Merged
feat: add WebviewBuilder::on_new_window and WebviewBuilder::on_document_title_changed#13876lucasfernog merged 14 commits intotauri-apps:devfrom
WebviewBuilder::on_new_window and WebviewBuilder::on_document_title_changed#13876lucasfernog merged 14 commits intotauri-apps:devfrom
Conversation
Contributor
Package Changes Through 4deb58fThere are 10 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri-runtime with minor, @tauri-apps/api with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
lucasfernog
added a commit
to tauri-apps/wry
that referenced
this pull request
Aug 12, 2025
currently the new_window_req_handler is fired on navigation events, which is incorrect as it calls the handler on iframe navigations and doesn't call it on window.open calls, not matching behavior on other platforms this PR changes it to run under [`webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:`](https://developer.apple.com/documentation/webkit/wkuidelegate/webview(_:createwebviewwith:for:windowfeatures:)?language=objc) instead I've noticed this when testing tauri-apps/tauri#13876
Member
|
on_new_window still needs quite a bit of work to be introduced to Tauri, I'll open some wry PRs |
lucasfernog
added a commit
to tauri-apps/wry
that referenced
this pull request
Aug 13, 2025
* fix(macos): new_window_req not firing on window.open currently the new_window_req_handler is fired on navigation events, which is incorrect as it calls the handler on iframe navigations and doesn't call it on window.open calls, not matching behavior on other platforms this PR changes it to run under [`webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:`](https://developer.apple.com/documentation/webkit/wkuidelegate/webview(_:createwebviewwith:for:windowfeatures:)?language=objc) instead I've noticed this when testing tauri-apps/tauri#13876 * fix build * fix coordinates * fix features
lucasfernog
added a commit
to tauri-apps/wry
that referenced
this pull request
Aug 13, 2025
follow-up for #1596 ref tauri-apps/tauri#13876
lucasfernog
added a commit
to tauri-apps/wry
that referenced
this pull request
Aug 13, 2025
2 tasks
lucasfernog
added a commit
to tauri-apps/wry
that referenced
this pull request
Aug 16, 2025
…wn (#1601) * feat(linux): craete webview on new_window_req follow-up for #1596 ref tauri-apps/tauri#13876 * refactor: allow new_window_req_handler to create the webview on its own * add webview getter * clippy regression * macos fixes * enhance platform support * fix deadlock on windows * fix mac build
lucasfernog
approved these changes
Aug 16, 2025
Contributor
|
@lucasfernog Ideally I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add
WebviewBuilder::on_new_windowandWebviewBuilder::on_document_title_changed