Skip to content

feat(tauri): impl App::set_device_event_filter for AppHandle also#14008

Merged
lucasfernog merged 3 commits intotauri-apps:devfrom
WSH032:feat/apphandle-set_device_event_filter
Aug 16, 2025
Merged

feat(tauri): impl App::set_device_event_filter for AppHandle also#14008
lucasfernog merged 3 commits intotauri-apps:devfrom
WSH032:feat/apphandle-set_device_event_filter

Conversation

@WSH032
Copy link
Contributor

@WSH032 WSH032 commented Aug 15, 2025

Not sure why this API wasn't added before: #5562 (comment). For the symmetry, I submitted this PR.

I encountered this issue while implementing API bindings for pytauri. Generally, for APIs that exist on both App and AppHandle, I only implement them on AppHandle; I only implement APIs specific to App (such as run and run_iter) on App itself.

In other words, I'm fine with whether this PR gets merged or not. I just want to know if there was a deliberate reason for not adding this API to AppHandle.

@WSH032 WSH032 requested a review from a team as a code owner August 15, 2025 08:36
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Aug 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2025

Package Changes Through 15bc3b9

There are 10 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri-runtime with minor, @tauri-apps/api with minor, tauri-plugin with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.7.0 2.8.0
tauri-utils 2.6.0 2.7.0
tauri-macos-sign 2.1.0 2.2.0
tauri-bundler 2.5.2 2.6.0
tauri-runtime 2.7.1 2.8.0
tauri-runtime-wry 2.7.2 2.8.0
tauri-codegen 2.3.1 2.3.2
tauri-macros 2.3.2 2.3.3
tauri-plugin 2.3.1 2.4.0
tauri-build 2.3.1 2.3.2
tauri 2.7.0 2.8.0
@tauri-apps/cli 2.7.1 2.8.0
tauri-cli 2.7.1 2.8.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

Judging by the tao docs i see no reason why this shouldn't be available on the handle as well.

lucasfernog
lucasfernog previously approved these changes Aug 16, 2025
@lucasfernog lucasfernog merged commit 22d6bca into tauri-apps:dev Aug 16, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap Aug 16, 2025
@WSH032 WSH032 deleted the feat/apphandle-set_device_event_filter branch August 18, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

3 participants