feat(tauri): impl App::set_device_event_filter for AppHandle also#14008
Merged
lucasfernog merged 3 commits intotauri-apps:devfrom Aug 16, 2025
Merged
Conversation
Contributor
Package Changes Through 15bc3b9There are 10 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri-runtime with minor, @tauri-apps/api with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Member
|
Judging by the tao docs i see no reason why this shouldn't be available on the handle as well. |
This was referenced Aug 15, 2025
lucasfernog
previously approved these changes
Aug 16, 2025
lucasfernog
reviewed
Aug 16, 2025
lucasfernog
reviewed
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why this API wasn't added before: #5562 (comment). For the symmetry, I submitted this PR.
I encountered this issue while implementing API bindings for pytauri. Generally, for APIs that exist on both
AppandAppHandle, I only implement them onAppHandle; I only implement APIs specific toApp(such asrunandrun_iter) onAppitself.In other words, I'm fine with whether this PR gets merged or not. I just want to know if there was a deliberate reason for not adding this API to
AppHandle.