Skip to content

fix(windows): binary patching 32 bit updater type#14065

Merged
lucasfernog merged 2 commits intotauri-apps:devfrom
Legend-Master:binary-patching-32-bit
Aug 24, 2025
Merged

fix(windows): binary patching 32 bit updater type#14065
lucasfernog merged 2 commits intotauri-apps:devfrom
Legend-Master:binary-patching-32-bit

Conversation

@Legend-Master
Copy link
Contributor

Fix #14059

I have tested this in the repo for the API example through cargo run --package tauri-cli -- build --target="i686-pc-windows-msvc" and cargo run --package tauri-cli -- build --target="x86_64-pc-windows-msvc"

@Legend-Master Legend-Master requested a review from a team as a code owner August 23, 2025 14:50
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Aug 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2025

Package Changes Through ff81e4a

There are 1 changes which include tauri-bundler with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.6.0 2.6.1
@tauri-apps/cli 2.8.1 2.8.2
tauri-cli 2.8.0 2.8.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Contributor Author

@kandrelczyk you're indeed correct about the cause, but instead of using usize, we need to check pe.is_64 to determine the pointer size, since usize is the CLI's target not the user's executable file's

@kandrelczyk
Copy link
Contributor

Great. I just finished setting up windows environment. I guess I will have it ready for the next one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

Failed to add bundler type to the binary

3 participants