fix(bundler/cli): set user-agent when fetching build tools#14408
fix(bundler/cli): set user-agent when fetching build tools#14408FabianLars merged 2 commits intodevfrom
Conversation
| .map(|alt_url| (ureq::agent(), alt_url)) | ||
| .map(|alt_url| { | ||
| ( | ||
| ureq::Agent::config_builder() |
There was a problem hiding this comment.
we may want to add the platform certs here as well but nobody complained so far so idk
There was a problem hiding this comment.
Any reason not to use base_ureq_agent here?
There was a problem hiding this comment.
i assumed that setting the proxy may be a bad idea here. but idk i just kept it as-is cause i wasn't involved in that part at all and idk the requirements or expectations.
There was a problem hiding this comment.
Alright, let's go with this for now and see if anyone using it actually wants to change this
Package Changes Through ccb47adThere are 3 changes which include tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| .map(|alt_url| (ureq::agent(), alt_url)) | ||
| .map(|alt_url| { | ||
| ( | ||
| ureq::Agent::config_builder() |
There was a problem hiding this comment.
Any reason not to use base_ureq_agent here?
2 participants
No description provided.