fix(core): properly handle async errors in addPluginListener#14464
Merged
Legend-Master merged 2 commits intoNov 15, 2025
Merged
Conversation
Contributor
Package Changes Through bb2841aThere are 1 changes which include @tauri-apps/api with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
approved these changes
Nov 15, 2025
The previous implementation used .then() after invoke() without await, which prevented the catch block from handling rejected promises. Now using await to properly catch errors and allow fallback to camelCase registerListener method.
Legend-Master
force-pushed
the
fix/addpluginlistener-async-error-handling
branch
from
8c5b7c2 to
bb2841a
Compare
This was referenced Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used .then() after invoke() without await, which prevented the catch block from handling rejected promises. Now using await to properly catch errors and allow fallback to camelCase registerListener method.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The
addPluginListenerfunction doesn't properly catch async errors because.then()is called on the Promise withoutawait, preventing thecatchblock from handling rejected promises.What is the new behavior?
Now using
awaitbeforeinvoke()calls to properly catch async errors and allow fallback to the camelCaseregisterListenermethod.Does this PR introduce a breaking change?
No