Skip to content

feat(CTA): add initial vite support with vue and vue-ts - #1467

Merged
lucasfernog merged 5 commits into
devfrom
feat/cta-vite
Apr 13, 2021
Merged

feat(CTA): add initial vite support with vue and vue-ts#1467
lucasfernog merged 5 commits into
devfrom
feat/cta-vite

Conversation

@amrbashir

@amrbashir amrbashir commented Apr 12, 2021

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir
amrbashir requested a review from a team as a code owner April 12, 2021 22:27
@amrbashir

Copy link
Copy Markdown
Member Author

does this PR need a changefile ?

@amrbashir

Copy link
Copy Markdown
Member Author

Any future vite template will only have to include a folder under templates/vite with the modified content.
The folder name must be a name that is one of vite's official templates for ex: vanilla-ts, react or lit-element-ts

@jbolda

jbolda commented Apr 13, 2021

Copy link
Copy Markdown
Member

does this PR need a changefile ?

I think it makes sense to have one. It's a new "feature" so might as well highlight it.

Comment thread tooling/create-tauri-app/src/recipes/react.ts
@jbolda

jbolda commented Apr 13, 2021

Copy link
Copy Markdown
Member

Any future vite template will only have to include a folder under templates/vite with the modified content.
The folder name must be a name that is one of vite's official templates for ex: vanilla-ts, react or lit-element-ts

Do you think there is value in having extra template files for every vite template?

@amrbashir

amrbashir commented Apr 13, 2021

Copy link
Copy Markdown
Member Author

Do you think there is value in having extra template files for every vite template?

No not really. The template files are modified to just add the tauri logo next to vue .
If you can do without that then there is no need to have these files.

I wanted to add an example showing the usage of some tauri's api, maybe just a simple communication between js and rust but that can quickly be like the examples repo

@jbolda

jbolda commented Apr 13, 2021

Copy link
Copy Markdown
Member

Do you think there is value in having extra template files for every vite template?

No not really. The template files are modified to just add the tauri logo next to vue .
If you can do without that then there is no need to have these files.

I wanted to add an example showing the usage of some tauri's api, maybe just a simple communication between js and rust but that can quickly be like the examples repo

Well, it is probably worthwhile to get this in and we can adjust later. I wonder if maybe we can do some sort of "common" template files that all of the examples can use (or at least within the same framework / group) since it probably does make sense long term to show the API use in some manner.

@lucasfernog
lucasfernog merged commit 80b7bd7 into dev Apr 13, 2021
@lucasfernog
lucasfernog deleted the feat/cta-vite branch April 13, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants