Fix: Updater signer failed signing file without extension#14713
Conversation
Package Changes Through d8c2568There are 7 changes which include tauri-utils with patch, tauri-build with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime-wry with patch, tauri-runtime with patch, tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
left a comment
There was a problem hiding this comment.
Thanks! Could you also add a change file?
https://github.com/tauri-apps/tauri/blob/dev/.changes/README.md
| // Previously if the file didn't have an extension, it broke as | ||
| // bin_path.extension().unwrap().to_os_string(); returned None and unwrwap failed. |
There was a problem hiding this comment.
I think the code is self explanatory enough that we could remove this comment
And maybe we could add a TODO comment here like 'TODO: use with_added_extension when we bump MSRV to > 1.91'
|
You'll need to re-sign your first commit 0b0bf8a and force push so I can merge this one |
|
@Legend-Master Do you have a guide on how to sign only my first commit? Thanks in advance |
|
I used to use the method mentioned in https://stackoverflow.com/a/54987693 |
b73b06f to
d8c2568
Compare
|
@Legend-Master Done! Thanks for the guide |

If we tried to sign a file without extension (for example in linux)
Before:
bin_path.extension().unwrap().to_os_string();returned None and unwrap of course failed.
Change: