fea(wix): add minimum webview2 version support#14793
Conversation
Package Changes Through d468f0dThere are 9 changes which include tauri-macos-sign with patch, tauri-build with patch, tauri with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri-utils with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| /// Try to ensure that the WebView2 version is equal to or newer than this version, | ||
| /// if the user's WebView2 is older than this version, | ||
| /// the installer will try to trigger a WebView2 update. | ||
| pub minimum_webview2_version: Option<String>, |
There was a problem hiding this comment.
Adding a field here is technically breaking as well...
There was a problem hiding this comment.
any better idea than making it all Builder patterns in v3?
There was a problem hiding this comment.
marking minors as breaking? 😂
| <RegistrySearch Id="Webview2VersionSystemx64" Root="HKLM" Key="SOFTWARE\WOW6432Node\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Name="pv" Type="raw" /> | ||
| <RegistrySearch Id="Webview2VersionSystemx86" Root="HKLM" Key="SOFTWARE\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Name="pv" Type="raw" /> | ||
| <RegistrySearch Id="Webview2VersionUser" Root="HKCU" Key="SOFTWARE\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Name="pv" Type="raw"/> |
There was a problem hiding this comment.
This is the same as the old version that used Win64="no" but i guess being more explicit is good.
There was a problem hiding this comment.
The description of the Win64 attribute is kind of confusing that I never really understood it, so I just mirrored the checks from the NSIS script
|
p.s. couldn't test it but i trust you :P |
| <RegistrySearch Id="Webview2VersionSystemx64" Root="HKLM" Key="SOFTWARE\WOW6432Node\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Name="pv" Type="raw" /> | ||
| <RegistrySearch Id="Webview2VersionSystemx86" Root="HKLM" Key="SOFTWARE\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Name="pv" Type="raw" /> | ||
| <RegistrySearch Id="Webview2VersionUser" Root="HKCU" Key="SOFTWARE\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Name="pv" Type="raw"/> |
There was a problem hiding this comment.
The description of the Win64 attribute is kind of confusing that I never really understood it, so I just mirrored the checks from the NSIS script
* feat(wix): add minimum webview2 version option * Add change file * Format * Move comments inside `#if` block * add breaking change notes * Add deprecation to description schema * Merge remote-tracking branch 'upstream/dev' into wix-minimum-webview2-version * Merge branch 'dev' into wix-minimum-webview2-version
* feat(wix): add minimum webview2 version option * Add change file * Format * Move comments inside `#if` block * add breaking change notes * Add deprecation to description schema * Merge remote-tracking branch 'upstream/dev' into wix-minimum-webview2-version * Merge branch 'dev' into wix-minimum-webview2-version
2 participants
Port #10339 to MSI (Wix) installer
The old
bundle > windows > nsis > minimumWebview2Versionis now deprecated in favor ofbundle > windows > minimumWebview2VersionA note, in case we ever want to support this for MSIX, it seems like it's possible through https://learn.microsoft.com/en-us/uwp/schemas/appxpackage/uapmanifestschema/element-win32dependencies-externaldependency