fix(tauri): don't remove once listener inside async task #1506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Spawning an async task to remove the once listener caused it to be able to be called multiple times before being removed. This design choice was previously made due to deadlock happening when removing the event from inside
event::Listeners::once(/*...*/)
. That was because the listeners were already locked insidetrigger
when asked to be removed.trigger
now handles removing once handlers, preventing a second lock attempt.Window::trigger
is nowpub
notpub(crate)
.EventHandler
return toonce
andonce_global
could be considered breaking if the result of the expression (previously()
) was used directly instead of adding a semicolon. The fix in downstream code affected by it is adding a semicolon.IIRC, the
fn once
deadlock fix was happening when callingtrigger
. If there are more cases in which it was happening that this doesn't fix, let me know.