Skip to content

fix(tauri): don't remove once listener inside async task #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

chippers
Copy link
Member

@chippers chippers commented Apr 15, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Spawning an async task to remove the once listener caused it to be able to be called multiple times before being removed. This design choice was previously made due to deadlock happening when removing the event from inside event::Listeners::once(/*...*/). That was because the listeners were already locked inside trigger when asked to be removed. trigger now handles removing once handlers, preventing a second lock attempt.

  • Window::trigger is now pub not pub(crate).
  • Adding EventHandler return to once and once_global could be considered breaking if the result of the expression (previously ()) was used directly instead of adding a semicolon. The fix in downstream code affected by it is adding a semicolon.

IIRC, the fn once deadlock fix was happening when calling trigger. If there are more cases in which it was happening that this doesn't fix, let me know.

Spawning an async task to remove the once listener caused it to be able to be
called multiple times before being removed. This design choice was previously
made due to deadlock happening when removing the event from inside `fn once`.
That was because the listeners were already locked inside the trigger when
asked to be removed. `fn trigger` now handles removing once handlers
@chippers chippers requested a review from a team as a code owner April 15, 2021 05:44
@chippers chippers requested a review from a team April 15, 2021 05:44
@nothingismagick nothingismagick merged commit ece243d into dev Apr 15, 2021
@nothingismagick nothingismagick deleted the fix/event-once-deadlock branch April 15, 2021 06:11
@chippers chippers mentioned this pull request Apr 16, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants