Skip to content

Refactors#15117

Merged
Legend-Master merged 8 commits into
tauri-apps:devfrom
sftse:refactors
Mar 20, 2026
Merged

Refactors#15117
Legend-Master merged 8 commits into
tauri-apps:devfrom
sftse:refactors

Conversation

@sftse

@sftse sftse commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Found some odd patterns to clean up, prompted by #15065.

We could probably also go in the other direction and increase the scope of async instead of decreasing it like here, but the current use of safe_block_on is in a weird spot and needs more switching between async and blocking code.

@sftse
sftse requested a review from a team as a code owner March 18, 2026 15:00
@sftse

sftse commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

safe_block_on is no longer used after this PR, will follow up with a PR to clean it up and make pub. Still used, must have missed it.

@github-actions

github-actions Bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through f483655

There are 7 changes which include tauri-macos-sign with patch, tauri-build with patch, tauri with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-utils with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.8.3 2.8.4
tauri-macos-sign 2.3.3 2.3.4
tauri-bundler 2.8.1 2.8.2
tauri-runtime 2.10.1 2.10.2
tauri-runtime-wry 2.10.1 2.10.2
tauri-codegen 2.5.5 2.5.6
tauri-macros 2.5.5 2.5.6
tauri-plugin 2.5.4 2.5.5
tauri-build 2.5.6 2.5.7
tauri 2.10.3 2.11.0
@tauri-apps/cli 2.10.1 2.10.2
tauri-cli 2.10.1 2.10.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master

Copy link
Copy Markdown
Contributor

This seems to predate back to #2104 when we added it initially, not entirely sure the reason

Does anyone still remember the reason? 😂 I'll just merge this if no one remembers it

@FabianLars

Copy link
Copy Markdown
Member

i don't but that was shortly before my time here - imo just merge and monitor

Legend-Master
Legend-Master previously approved these changes Mar 19, 2026

@Legend-Master Legend-Master left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always

@Legend-Master

Copy link
Copy Markdown
Contributor

And you need to sign the commits 😂

themavik

This comment was marked as spam.

@Legend-Master
Legend-Master merged commit d730770 into tauri-apps:dev Mar 20, 2026
19 checks passed
@sftse
sftse deleted the refactors branch April 8, 2026 19:21
razein97 pushed a commit to razein97/tauri that referenced this pull request Apr 30, 2026
* refactor(tauri-build): make better use of OsString

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* refactor(tauri-build): dont wrap const value in function

* refactor(tauri-build): None codepath is never used, replace Option<Vec> with Vec

* refactor(tauri): use blocking apis where it makes sense

* refactor(tauri): better use of std::fs API

* refactor(tauri): rewind to start

* refactor(tauri): fmt

* add change file
razein97 pushed a commit to razein97/tauri that referenced this pull request Apr 30, 2026
* refactor(tauri-build): make better use of OsString

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* refactor(tauri-build): dont wrap const value in function

* refactor(tauri-build): None codepath is never used, replace Option<Vec> with Vec

* refactor(tauri): use blocking apis where it makes sense

* refactor(tauri): better use of std::fs API

* refactor(tauri): rewind to start

* refactor(tauri): fmt

* add change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants