changes(nsis): update Italian translations#15175
Conversation
- Add on top left after program name the program version. Es. "Tauri 1.0.0.0" - Add in file description "installer" after program name. Es. "Tauri installer"
|
Someone can check and merge to enable all users that are using Tauri to get the benfit of updated version for Italian language and im prove nsis script? Thanks. |
Package Changes Through a08ff3dThere are 11 changes which include tauri with minor, @tauri-apps/api with minor, tauri-macos-sign with patch, tauri-build with minor, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Added Italian language update for various Tauri packages.
| LangString chooseMaintenanceOption ${LANG_ITALIAN} "Seleziona l'operazione di manutenzione da eseguire." | ||
| LangString choowHowToInstall ${LANG_ITALIAN} "Seleziona come vuoi installare ${PRODUCTNAME}." | ||
| LangString createDesktop ${LANG_ITALIAN} "Crea scorciatoia sul Desktop" | ||
| LangString addOrReinstall ${LANG_ITALIAN} "Aggiungi/reinstalla componenti" |
There was a problem hiding this comment.
Sorry that I don't speak any Italian, but just looking by the patterns and a quick google translate to English, it seems to me that the old ones are more inline with the main ones we had in crates/tauri-bundler/src/bundle/windows/nsis/languages/English.nsh (e.g. Add/Reinstall components/Aggiungi/Reinstalla componenti)
There was a problem hiding this comment.
I'm italian mothertongue and I'm working as official Italian translator for many sofwtares (ex. Inno Setup and NSIS and many others).
The first basic rule for Italian grammar is that in a string only first letter of a paragraph is in uppercase (except own names).
For a good translation the understanding of the context is another base rule.
I checked the strings and I can confirm that my Italian translation is better then original, follow the rules of Italian grammaer and are related to the context of the string.
The I confirm my request to merge that.
Please also remind the changes about installer.nsi file
; Add in each installer window on top left program version after program name
Name "${PRODUCTNAME} ${VERSION}"
; Replace in program description after program name "Setup" with "Installer" - ex. "Tauri installer"
VIAddVersionKey "FileDescription" "${PRODUCTNAME} installer"
There was a problem hiding this comment.
Currently on my phone so I can't check the installer.nsi changes yet
Just want to ping @alex-sandri for a quick review since he wrote the original translation
There was a problem hiding this comment.
Please check NSIS official Italian language strings.
The original tauri italian strings don't follow Italian grammar rules (see below for explanation), don't match with NSIS Italian language, and sometimes use term out of the standard for the specific context..
And don't follow the flow difference for the paragraph about English/Italian.
In English you use "Do something for specific action".
In Italian we use "For a specific action do something"
It's also important to check the context and the standard for term used in the specific context. Ex:
"Crea scorciatoia sul desktop" (tauri original)
"Crea collegamento sul desktop" (standard translation for Windows)
"Scaricando il bootstrapper WebView2..." (tauri original)
It's wrong and not Italian. The progressive verb in this mode is an Italian grammar error.
The right Italian grammatical mode is "Sto scaricando" but is not usual in software context.
"Download bootstrapper WebView2..." (right one)
"Download" is more common then "Scarica" and the article is not necessary
When an operation can be done with mouse or keyboard is more common to use "Seleziona" instead "Clicca". "Seleziona" is an universal term for this context.
There was a problem hiding this comment.
Thanks for the explanation. I would still want to wait a bit for @alex-sandri since he wrote the original version
Will merge this if he didn't respond though
There was a problem hiding this comment.
Thanks.
I hope will apply the changes about installer.nsh
There was a problem hiding this comment.
@Legend-Master sorry if I wasn't able to reply sooner but I was a little busy at work. Anyway the changes proposed by @bovirus look good to me except for one small thing I commented on (line 10).
| VIProductVersion "${VERSIONWITHBUILD}" | ||
| VIAddVersionKey "ProductName" "${PRODUCTNAME}" | ||
| VIAddVersionKey "FileDescription" "${PRODUCTNAME}" | ||
| VIAddVersionKey "FileDescription" "${PRODUCTNAME} installer" |
There was a problem hiding this comment.
I feel like this probably shouldn't have been ${PRODUCTNAME} but an actual description of the app
Anyways, let's don't touch on this in this PR of the Italian translation update
There was a problem hiding this comment.
This the file description field content in exe file properties.
The standard if you don't setup is "${PRODUCTNAME}"
With this instruction you change in "${PRODUCTNAME} installer".
Because the exe is the installer not setup.
If you want I can open for installer.nsh a separate pull request.
| Var OldMainBinaryName | ||
|
|
||
| Name "${PRODUCTNAME}" | ||
| Name "${PRODUCTNAME} ${VERSION}" |
There was a problem hiding this comment.
I don't mind if we add the version to the name but it seems like just the app name is the standard here?
Anyways, let's don't touch on this in this PR of the Italian translation update
There was a problem hiding this comment.
Typically in this way you can see on top left after program name program version.
There was a problem hiding this comment.
@Legend-Master
OpenVideoDownloader installer use tauri and NSIS script and don't show the version info

There was a problem hiding this comment.
Please apply the changes to installer.nsh
There was a problem hiding this comment.
Let's move and discuss these in a separate PR and merge the Italian translations first
| LangString chooseMaintenanceOption ${LANG_ITALIAN} "Seleziona l'operazione di manutenzione da eseguire." | ||
| LangString choowHowToInstall ${LANG_ITALIAN} "Seleziona come vuoi installare ${PRODUCTNAME}." | ||
| LangString createDesktop ${LANG_ITALIAN} "Crea scorciatoia sul Desktop" | ||
| LangString addOrReinstall ${LANG_ITALIAN} "Aggiungi/reinstalla componenti" |
There was a problem hiding this comment.
Thanks for the explanation. I would still want to wait a bit for @alex-sandri since he wrote the original version
Will merge this if he didn't respond though
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
|
Please merge Italian strings changes (Italian.nsh). When you will merge this PR I will open a new PR only for changes about installer.nsh. Thanks. |
Legend-Master
left a comment
There was a problem hiding this comment.
Thanks @bovirus !
Also thanks for the review @alex-sandri !
* Italian language update * Base NSIS script improvements - Add on top left after program name the program version. Es. "Tauri 1.0.0.0" - Add in file description "installer" after program name. Es. "Tauri installer" * Italian language improvement * Add Italian language update to Tauri packages Added Italian language update for various Tauri packages. * Remove space * Apply suggestions from code review Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com> * Revert changes in `installer.nsi` * what has changed??? --------- Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com> Co-authored-by: Tony <legendmastertony@gmail.com>
* Italian language update * Base NSIS script improvements - Add on top left after program name the program version. Es. "Tauri 1.0.0.0" - Add in file description "installer" after program name. Es. "Tauri installer" * Italian language improvement * Add Italian language update to Tauri packages Added Italian language update for various Tauri packages. * Remove space * Apply suggestions from code review Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com> * Revert changes in `installer.nsi` * what has changed??? --------- Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com> Co-authored-by: Tony <legendmastertony@gmail.com>




Italian language update for NSIS
Please merge. Thanks.