Skip to content

feat(windows): NSIS uninstaller icon and header image support#15201

Merged
Legend-Master merged 26 commits into
tauri-apps:devfrom
Kokoro2336:feat/nsis-uninstaller-icon
Apr 8, 2026
Merged

feat(windows): NSIS uninstaller icon and header image support#15201
Legend-Master merged 26 commits into
tauri-apps:devfrom
Kokoro2336:feat/nsis-uninstaller-icon

Conversation

@Kokoro2336

Copy link
Copy Markdown
Contributor

This pr closes issue #15107.

Support uninstaller's icon, sidebar image and header image in NSIS.

@Kokoro2336
Kokoro2336 marked this pull request as ready for review April 5, 2026 15:18
@Kokoro2336
Kokoro2336 requested a review from a team as a code owner April 5, 2026 15:18
@github-actions

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through a1a466e

There are 10 changes which include tauri with minor, @tauri-apps/api with minor, tauri-macos-sign with patch, tauri-build with patch, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.10.1 2.11.0
tauri-utils 2.8.3 2.9.0
tauri-macos-sign 2.3.3 2.3.4
tauri-bundler 2.8.1 2.9.0
tauri-runtime 2.10.1 2.11.0
tauri-runtime-wry 2.10.1 2.11.0
tauri-codegen 2.5.5 2.5.6
tauri-macros 2.5.5 2.5.6
tauri-plugin 2.5.4 2.5.5
tauri-build 2.5.6 2.5.7
tauri 2.10.3 2.11.0
@tauri-apps/cli 2.10.1 2.11.0
tauri-cli 2.10.1 2.11.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Kokoro2336

Copy link
Copy Markdown
Contributor Author

Now all the new features work as expected.

The uninstaller icon:

Screenshot 2026-04-06 123346

Sidebar image in welcome page:

Screenshot 2026-04-06 123355

Header image in uninstalling page:

Screenshot 2026-04-06 123402

Sidebar image in finish page:

Screenshot 2026-04-06 123410

@Kokoro2336 Kokoro2336 changed the title feat: NSIS uninstaller icon/image support. feat(windows): NSIS uninstaller icon/image support. Apr 6, 2026

@Legend-Master Legend-Master left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in general, just some nitpicks, and we'll also need a change file

Thanks!

Comment thread crates/tauri-bundler/src/bundle/windows/nsis/installer.nsi Outdated
Comment on lines +157 to 160
; Uninstaller header image
!if "${UNINSTALLERHEADERIMAGE}" != ""
!define MUI_HEADERIMAGE_UNBITMAP "${UNINSTALLERHEADERIMAGE}"
!endif

@Legend-Master Legend-Master Apr 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's group this with the HEADERIMAGE above instead, it makes it easier to see the relation to !else if "${UNINSTALLERHEADERIMAGE}" != ""

Actually, never mind, this aligns with the installer code above

Comment thread crates/tauri-utils/src/config.rs
@Kokoro2336
Kokoro2336 force-pushed the feat/nsis-uninstaller-icon branch from cddf07d to 6506140 Compare April 7, 2026 15:01
Comment thread crates/tauri-bundler/src/bundle/windows/nsis/installer.nsi
Comment thread crates/tauri-utils/src/config.rs Outdated
Kokoro2336 and others added 3 commits April 7, 2026 23:23
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
@Kokoro2336

Copy link
Copy Markdown
Contributor Author

@Legend-Master Just had a simple test for the modification, the feature still works fine. Any other problems?

@Kokoro2336
Kokoro2336 requested a review from Legend-Master April 7, 2026 16:10
Comment thread crates/tauri-utils/src/config.rs Outdated
Comment thread crates/tauri-utils/src/config.rs Outdated
Comment thread crates/tauri-utils/src/config.rs
Kokoro2336 and others added 2 commits April 8, 2026 00:12
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
@Kokoro2336
Kokoro2336 requested a review from Legend-Master April 7, 2026 16:24
Comment thread crates/tauri-utils/src/config.rs Outdated
Comment thread crates/tauri-bundler/src/bundle/settings.rs Outdated
Comment thread .changes/config.json Outdated
Comment thread .changes/feat-uninstaller-icon-image.md
@Kokoro2336
Kokoro2336 requested a review from Legend-Master April 8, 2026 07:05
Legend-Master
Legend-Master previously approved these changes Apr 8, 2026

@Legend-Master Legend-Master left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread crates/tauri-bundler/src/bundle/windows/nsis/installer.nsi
@Kokoro2336

Copy link
Copy Markdown
Contributor Author

I think it's now ready for merging!

Comment thread crates/tauri-bundler/src/bundle/windows/nsis/installer.nsi Outdated
@Kokoro2336

Copy link
Copy Markdown
Contributor Author

@Legend-Master Thanks for your assistance and patience! This might be my first PR merged into tauri's main repo :-)

@Legend-Master Legend-Master changed the title feat(windows): NSIS uninstaller icon/image support. feat(windows): NSIS uninstaller icon and header image support Apr 8, 2026
@Legend-Master
Legend-Master merged commit 926a57b into tauri-apps:dev Apr 8, 2026
26 checks passed
@Kokoro2336
Kokoro2336 deleted the feat/nsis-uninstaller-icon branch April 8, 2026 17:57
razein97 pushed a commit to razein97/tauri that referenced this pull request Apr 30, 2026
…apps#15201)

* feat: NSIS uninstaller support.

* chore: fix typo and update schema.

* fix: comments and alias.

* fix: add pages for uninst sidebar.

* chore: fix typo in comments of fields.

* fix: group HEADERIMAGE.

* fix: remove welcome/finish of uninstaller.

* fix: remove uninstaller_sidebar_image.

* Update crates/tauri-utils/src/config.rs

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* chore: revert comments.

* chore: update schema.

* Update crates/tauri-utils/src/config.rs

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* Update crates/tauri-utils/src/config.rs

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* fix: typo of installer_icon.

* chore: add change file.

* fix: typo.

* chore: update config.json.

* Update .changes/feat-uninstaller-icon-image.md

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* fix: revert alias.

* chore: update comments in settings.rs.

* chore: update comments.

* fix: installer.nsi

* fix: installer.nsi

---------

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
razein97 pushed a commit to razein97/tauri that referenced this pull request Apr 30, 2026
…apps#15201)

* feat: NSIS uninstaller support.

* chore: fix typo and update schema.

* fix: comments and alias.

* fix: add pages for uninst sidebar.

* chore: fix typo in comments of fields.

* fix: group HEADERIMAGE.

* fix: remove welcome/finish of uninstaller.

* fix: remove uninstaller_sidebar_image.

* Update crates/tauri-utils/src/config.rs

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* chore: revert comments.

* chore: update schema.

* Update crates/tauri-utils/src/config.rs

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* Update crates/tauri-utils/src/config.rs

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* fix: typo of installer_icon.

* chore: add change file.

* fix: typo.

* chore: update config.json.

* Update .changes/feat-uninstaller-icon-image.md

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>

* fix: revert alias.

* chore: update comments in settings.rs.

* chore: update comments.

* fix: installer.nsi

* fix: installer.nsi

---------

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] NSIS uninstaller icon, sidebar image and header image

2 participants