feat(nsis): add Vietnamese language support for installer.#15218
Conversation
|
Hey, thanks for contributing. You'll need also need to add this to |
|
Hey, thanks for the guidance — I’ve followed your instructions. I added the language entry to get_lang_data in crates/tauri-bundler/src/bundle/windows/nsis/mod.rs and made sure the file is using the .nsh extension and placed in the correct directory. Everything is wired up now on my side. Could you help take a quick look and review if this is the correct approach or if anything should be adjusted? |
Legend-Master
left a comment
There was a problem hiding this comment.
We'll also need a change file
https://github.com/tauri-apps/tauri/blob/dev/.changes/README.md
Also, have you tested the code?
Package Changes Through 91432b0There are 11 changes which include tauri with minor, @tauri-apps/api with minor, tauri-build with minor, tauri-macos-sign with patch, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
I have made the changes according to your instructions. |
Added support for the Vietnamese language in the project.
Legend-Master
left a comment
There was a problem hiding this comment.
Code looks good, could you give it a manual test before we merge it?
Thank you for the guidance. I have consulted PR #14824 and followed the instructions. I am now downloading the branch to my machine to run tests and will update the results later. |
|
There were a few failed test cases, but I wasn't the one causing the problem. test results on my machine: |
|
I created my own PR TanNhatCMS#1 to trigger tests on GitHub Actions, and everything seems fine except for some feedback from the AI review, but that's beyond my ability to change in this PR. |
|
Those are unrelated, just compile and generate a NSIS installer to verify it's translated would be fine |
I'm not sure how this is actually done in the Tauri project. In my Tauri project, I configured customLanguageFiles directly to the Vietnamese language file. After packaging the application, the NSIS installer worked and displayed Vietnamese; everything was fine. |
|
To me, usually just using the API example, treat it like a normal Tauri app
|
Legend-Master
left a comment
There was a problem hiding this comment.
Works for me from manual testing, thanks!
…s#15218) * Create Vietnamese * Add Vietnamese language support for NSIS bundler * chore rename * Merge branch 'dev' into patch-1 * Add Vietnamese language support for NSIS installer * Merge branch 'dev' into patch-1 * Add Vietnamese language support Added support for the Vietnamese language in the project. * Update change-pr-15218.md * Merge branch 'dev' into patch-1 * Added Vietnamese translations for the NSIS installer * Merge branch 'dev' into patch-1
…s#15218) * Create Vietnamese * Add Vietnamese language support for NSIS bundler * chore rename * Merge branch 'dev' into patch-1 * Add Vietnamese language support for NSIS installer * Merge branch 'dev' into patch-1 * Add Vietnamese language support Added support for the Vietnamese language in the project. * Update change-pr-15218.md * Merge branch 'dev' into patch-1 * Added Vietnamese translations for the NSIS installer * Merge branch 'dev' into patch-1
This pull request adds support for the Vietnamese language to the Windows NSIS installer in the
tauri-bundlercrate. The main changes include the addition of a Vietnamese translation file with relevant installer strings and updating the language data loader to recognize Norwegian.Vietnamese language support:
Vietnamese.nsh) with installer strings for various installation and maintenance scenarios.get_lang_datafunction inmod.rsto include and recognize the Vietnamese language file.