Skip to content

feat: #1528 wix supports custom templates #1529

Merged
lucasfernog merged 10 commits intotauri-apps:devfrom
Cupnfish:dev
Apr 24, 2021
Merged

feat: #1528 wix supports custom templates #1529
lucasfernog merged 10 commits intotauri-apps:devfrom
Cupnfish:dev

Conversation

@Cupnfish
Copy link
Contributor

@Cupnfish Cupnfish commented Apr 18, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
    Wix supports custom templates #1528
    Other information:

@Cupnfish Cupnfish requested a review from a team April 18, 2021 10:36
@Cupnfish Cupnfish changed the title Wix supports custom templates feat: #1528 wix supports custom templates Apr 18, 2021
@Cupnfish Cupnfish requested a review from a team April 18, 2021 11:29
Copy link
Member

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops. We need a .changes file here please.

@Cupnfish Cupnfish requested a review from a team as a code owner April 18, 2021 14:03
@lucasfernog
Copy link
Member

Can we implement some kind of solution to merge two wix files? This solution is a little scary since the user would have trouble maintaining Tauri changes.

@Cupnfish
Copy link
Contributor Author

I haven’t come up with any other ideas yet, but I think this feature is necessary, so if anyone has a better idea, feel free to share.

@lucasfernog
Copy link
Member

I need to try merging two XMLs using serde, but i'm busy with the plugin system right now.

@Cupnfish
Copy link
Contributor Author

Do I need to close the PR?

@lucasfernog
Copy link
Member

Let's wait to see if I can come up with a solution that simplifies your life :)

@lucasfernog
Copy link
Member

I think using Fragments is the right way to do this.

@lucasfernog
Copy link
Member

I've finished implementing Wix fragments support. We can also add support to WIX include files if you need.

@Cupnfish
Copy link
Contributor Author

Cupnfish commented Apr 24, 2021

Thank you for your help.
It’s great, I love it. WIX include files is necessary.
In addition, I still have a problem to solve, the current WIX template is the default download edge webview, for other rust projects do not need this, packaging with this is very inconvenient, there is no way to solve this problem?
I think I should mention a new issue.
#1606

@lucasfernog lucasfernog reopened this Apr 24, 2021
@lucasfernog
Copy link
Member

Since you're using the bundler outside Tauri, i think we can reconsider this :)

@lucasfernog
Copy link
Member

If we start getting attention with the bundler as a library, we should consider moving it to its own repo.

@lucasfernog lucasfernog merged commit ebe755a into tauri-apps:dev Apr 24, 2021
@Cupnfish
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants