fix(cli): Honor a specified NDK version by setting NDK_HOME, if set (#14860) - #15344
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the NDK_HOME environment variable is set or not, the NDK used by the cli is the lastest version installed at ANDROID_HOME/ndk directory. And if the cli cannot find any ndk inside the ANDROID_HOME/ndk, it try to install the version 29.0.13846066.
We got always this type of output even we set NDK_HOME or not, where the version is the latest or 29.0.13846066:
Now, after this update, when we launch for example:
we get the output:
Fixes #14860
Closes #14398