fix: set_as_windows_menu_for_nsapp command wrongly called set_as_help_menu_for_nsapp#15386
Merged
Legend-Master merged 1 commit intoMay 15, 2026
Conversation
Contributor
Package Changes Through 9626b03There are 5 changes which include tauri-bundler with minor, tauri-cli with minor, tauri-utils with minor, tauri with patch, tauri-build with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
previously approved these changes
May 15, 2026
Legend-Master
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Could you also add a change file?
https://github.com/tauri-apps/tauri/blob/dev/.changes/README.md
Also you'll need to sign your commits for me to merge this
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
DominikPeters
force-pushed
the
fix/menu-window-nsapp-command
branch
from
May 15, 2026 16:05
bec77ff to
15b6386
Compare
DominikPeters
force-pushed
the
fix/menu-window-nsapp-command
branch
from
May 15, 2026 16:09
15b6386 to
9626b03
Compare
Contributor
Author
|
Hi! I signed the commit and added a change file. |
set_as_windows_menu_for_nsapp command wrongly called set_as_help_menu_for_nsapp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes the
plugin:menu|set_as_windows_menu_for_nsappcommand handler so it callsSubmenu::set_as_windows_menu_for_nsapp()instead ofSubmenu::set_as_help_menu_for_nsapp(). This was probably a typo.Why
Submenu.setAsWindowsMenuForNSApp()currently invokes the correct JavaScript command name, but the Rust command implementation routes it to the Help menu setter. As a result, apps using the JS API do not register their Window submenu as the AppKit Window menu, so macOS cannot attach native Window menu behavior such as the system window/tiling entries.The app-menu auto-registration path for
WINDOW_SUBMENU_IDalready calls the correct method; this patch makes the JS command path consistent with it.Related
muda::Submenu::set_as_windows_menu_for_nsapp; this PR fixes Tauri’s JS command path so it calls that corrected native method.Validation
cargo fmt --check --allcargo check -p tauri --lib