Fix aliased plugin imports in v1 migration - #15454
Merged
Legend-Master merged 2 commits intoJun 1, 2026
Merged
Conversation
fallintoplace
marked this pull request as ready for review
May 30, 2026 23:00
Contributor
Package Changes Through 51f23f9There are 5 changes which include tauri-utils with patch, tauri-bundler with patch, tauri with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
previously approved these changes
May 31, 2026
Contributor
There was a problem hiding this comment.
Thanks! Could you also add a change file?
https://github.com/tauri-apps/tauri/blob/dev/.changes/README.md
Also you'll need to sign your commits for me to merge this
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
fallintoplace
force-pushed
the
fix/migrate-plugin-alias-imports
branch
from
May 31, 2026 14:44
362e3d1 to
8bbc57e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tauri-apps/apiRoot cause
The migrator generated aliased namespace imports as
import * as cli as superCli from "...", which is not valid ESM and breaks migrated code for inputs likeimport { cli as superCli } from "@tauri-apps/api".Testing
cargo test -p tauri-cli 'migrate::migrations::v1::frontend::tests::migrates'