Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): pull package info from tauri.conf.json if set #1581

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner April 22, 2021 14:01
@lucasfernog lucasfernog requested a review from a team April 22, 2021 14:01
@lemarier
Copy link
Member

lemarier commented Apr 22, 2021

Looks good <3! The main issue I'm seeing is if someone forgot to update the Cargo.toml version (they have to change it at 2 places), the app will announce the tauri.conf.json version but will mismatch the Cargo.toml version who is the real runtime version.

What do you think? Maybe I'm thinking wrong?

@lucasfernog
Copy link
Member Author

The user do not need to update both versions I think (unless they're using the cargo environment variables). The bundler already pulls from the config, and the updater you wrote is using the PackageInfo struct.

@lucasfernog lucasfernog merged commit 8fd1baf into dev Apr 22, 2021
@lucasfernog lucasfernog deleted the fix/package-info branch April 22, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants