fix(core): pull package info from tauri.conf.json if set#1581
Merged
lucasfernog merged 2 commits intodevfrom Apr 22, 2021
Merged
fix(core): pull package info from tauri.conf.json if set#1581lucasfernog merged 2 commits intodevfrom
lucasfernog merged 2 commits intodevfrom
Conversation
Member
|
Looks good <3! The main issue I'm seeing is if someone forgot to update the Cargo.toml version (they have to change it at 2 places), the app will announce the tauri.conf.json version but will mismatch the Cargo.toml version who is the real runtime version. What do you think? Maybe I'm thinking wrong? |
Member
Author
|
The user do not need to update both versions I think (unless they're using the cargo environment variables). The bundler already pulls from the config, and the updater you wrote is using the PackageInfo struct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: