Skip to content

feat(core): add error message on error::CreateWebview#1602

Merged
lucasfernog merged 1 commit intodevfrom
feat/create-webview-error-message
Apr 23, 2021
Merged

feat(core): add error message on error::CreateWebview#1602
lucasfernog merged 1 commit intodevfrom
feat/create-webview-error-message

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The error on panic isn't clear without the message.

@lucasfernog lucasfernog requested a review from a team as a code owner April 23, 2021 17:42
@lucasfernog lucasfernog requested a review from a team April 23, 2021 17:42
@lucasfernog lucasfernog merged commit 7471e34 into dev Apr 23, 2021
@lucasfernog lucasfernog deleted the feat/create-webview-error-message branch April 23, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant