Skip to content

fix(api): export commonjs chunks with .cjs extension, fix #1625#1627

Merged
lucasfernog merged 1 commit intodevfrom
fix/api-cjs-chunks
Apr 26, 2021
Merged

fix(api): export commonjs chunks with .cjs extension, fix #1625#1627
lucasfernog merged 1 commit intodevfrom
fix/api-cjs-chunks

Conversation

@amrbashir
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner April 26, 2021 16:29
@amrbashir amrbashir requested a review from a team April 26, 2021 16:29
@lucasfernog lucasfernog merged commit ddcd923 into dev Apr 26, 2021
@lucasfernog lucasfernog deleted the fix/api-cjs-chunks branch April 26, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants