Skip to content

chore: shift CTA from bin to .ts - #1651

Merged
jbolda merged 3 commits into
devfrom
chore/shift-cta-out-of-bin
Apr 29, 2021
Merged

jbolda merged 3 commits into
devfrom
chore/shift-cta-out-of-bin

Conversation

@jbolda

@jbolda jbolda commented Apr 29, 2021

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)
This shifts most of the code in CTA into .ts so we can properly type everything.

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@jbolda
jbolda requested a review from a team as a code owner April 29, 2021 02:18
@jbolda
jbolda force-pushed the chore/shift-cta-out-of-bin branch from 4ac1ffc to bab881a Compare April 29, 2021 02:20
@jbolda
jbolda merged commit c3acbd6 into dev Apr 29, 2021
@jbolda
jbolda deleted the chore/shift-cta-out-of-bin branch April 29, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants