Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli.rs): allow using cross instead of cargo, add target triple arg #1664

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Some users are using cross instead of cargo (either to use Docker or experimenting arm support). This PR allows you to run tauri build --runner cross or settings runner: "cross" under tauri.conf.json > build.

@lucasfernog lucasfernog requested a review from a team as a code owner April 30, 2021 15:43
@lucasfernog lucasfernog requested review from a team April 30, 2021 15:43
@lucasfernog
Copy link
Member Author

Also related to #941

@lucasfernog lucasfernog merged commit 5c1fe52 into dev Apr 30, 2021
@lucasfernog lucasfernog deleted the feat/cross-support branch April 30, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants