Skip to content

feat(cli.rs/info): get webview2 version on windows - #1669

Merged
lucasfernog merged 3 commits into
devfrom
feat/cli.rs/webview2-info
May 4, 2021
Merged

feat(cli.rs/info): get webview2 version on windows#1669
lucasfernog merged 3 commits into
devfrom
feat/cli.rs/webview2-info

Conversation

@amrbashir

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir
amrbashir requested a review from a team as a code owner May 1, 2021 02:10
@amrbashir
amrbashir requested a review from a team May 1, 2021 02:10
@amrbashir
amrbashir requested a review from a team May 4, 2021 02:22

@lucasfernog lucasfernog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@lucasfernog
lucasfernog merged commit 2b4e2b7 into dev May 4, 2021
@lucasfernog
lucasfernog deleted the feat/cli.rs/webview2-info branch May 4, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants